Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added support to cast NullArray to all other types #589

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

flaneur2020
Copy link
Contributor

this PR is a port of apache/arrow-rs#884

@flaneur2020 flaneur2020 changed the title allow null array to be cased to all other types allow null array to be casted to all other types Nov 9, 2021
@flaneur2020 flaneur2020 force-pushed the port-cast branch 2 times, most recently from 0b6b856 to 589ed9f Compare November 9, 2021 07:04
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #589 (0b607ae) into main (e9d618c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   78.99%   78.97%   -0.03%     
==========================================
  Files         399      400       +1     
  Lines       24752    24831      +79     
==========================================
+ Hits        19554    19611      +57     
- Misses       5198     5220      +22     
Impacted Files Coverage Δ
src/compute/cast/mod.rs 93.91% <100.00%> (+2.57%) ⬆️
tests/it/compute/cast.rs 99.37% <100.00%> (+0.01%) ⬆️
src/io/ipc/read/array/dictionary.rs 42.10% <0.00%> (-7.90%) ⬇️
src/io/ipc/read/common.rs 80.32% <0.00%> (-6.41%) ⬇️
src/datatypes/schema.rs 37.93% <0.00%> (-5.82%) ⬇️
src/io/ipc/read/array/fixed_size_list.rs 25.00% <0.00%> (-5.44%) ⬇️
src/io/ipc/read/array/list.rs 43.75% <0.00%> (-4.64%) ⬇️
src/array/growable/mod.rs 21.56% <0.00%> (-4.63%) ⬇️
src/io/ipc/read/array/map.rs 25.00% <0.00%> (-4.04%) ⬇️
src/io/ipc/read/array/struct_.rs 92.85% <0.00%> (-3.44%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d618c...0b607ae. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit add3e2a into jorgecarleitao:main Nov 10, 2021
@jorgecarleitao
Copy link
Owner

Thanks a lot, @flaneur2020 !

@jorgecarleitao jorgecarleitao added the feature A new feature label Nov 10, 2021
@jorgecarleitao jorgecarleitao changed the title allow null array to be casted to all other types Allow NullArray to be casted to all other types Nov 10, 2021
@jorgecarleitao jorgecarleitao changed the title Allow NullArray to be casted to all other types Added support to cast NullArray to all other types Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants